search

JuliaData / Avro.jl

Pure Julia implementation for reading/writing data in the Avro format
MIT License
16 stars 6 forks source link

Default to millisecond DateTime precision #14

Closed andyferris closed 3 years ago

andyferris commented 3 years ago

Julia's internal DateTime uses millisecond precision, so this seems simplest and even saves a byte or two.

On the other hand, Time is in nanoseconds and I've left the logical time types in microseconds to capture at least some of this precision.

I also added writevalue (and nbytes) methods for all these types, in case anyone needs to write to a schema containing these.

Resolves #8

codecov[bot] commented 3 years ago

Codecov Report

Merging #14 (9c950e0) into main (36a8402) will decrease coverage by 0.77%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   78.02%   77.25%   -0.78%     
==========================================
  Files          13       13              
  Lines         801      809       +8     
==========================================
  Hits          625      625              
- Misses        176      184       +8
Impacted Files Coverage Δ
src/types/logical.jl 55.17% <33.33%> (-4.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36a8402...9c950e0. Read the comment docs.