JuliaData / CSV.jl

Utility library for working with CSV and other delimited files in the Julia programming language
https://csv.juliadata.org/
Other
470 stars 140 forks source link

Fix multithreaded fail on trailing empty column #1098

Closed Liozou closed 1 year ago

Liozou commented 1 year ago

While looking at https://github.com/JuliaData/CSV.jl/issues/1095 I noticed that multi-threaded parsing currently fails (and falls back to single-thread) when a file ends with a trailing empty column, i.e. a line ending with a column delimiter with no trailing newline. This fixes that.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (07fb6c2) 90.40% compared to head (108e2de) 90.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1098 +/- ## ========================================== + Coverage 90.40% 90.43% +0.02% ========================================== Files 9 9 Lines 2294 2299 +5 ========================================== + Hits 2074 2079 +5 Misses 220 220 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaData/CSV.jl/pull/1098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData) | Coverage Δ | | |---|---|---| | [src/detection.jl](https://app.codecov.io/gh/JuliaData/CSV.jl/pull/1098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData#diff-c3JjL2RldGVjdGlvbi5qbA==) | `96.38% <100.00%> (+0.04%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.