Closed Liozou closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
07fb6c2
) 90.40% compared to head (5093e6b
) 90.42%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Reduce the
@error
introduced in https://github.com/JuliaData/CSV.jl/pull/1073 to a@warning
whenever previous warnings may explain why multithreaded parsing failed (typically, unequal number of columns per row). In those cases, it will print:If there is no possible explanation, this still shows a red
@error
saying:In both cases, a debug statement is printed as soon as multithread parsing failed (if the Context
debug
kwarg is set), whereas the@warning
or@error
only appears at the end of the fallback single-threaded parsing.I think this compromise allows us to still get error reports like https://github.com/JuliaData/CSV.jl/issues/1095, which are crucial to detect and allow use to fix underlying issues where multithreaded parsing should not fail (like https://github.com/JuliaData/CSV.jl/pull/1098 in this instance), while avoiding to stress the user with an
@error
when there is nothing to report.Close https://github.com/JuliaData/CSV.jl/issues/1095.