JuliaData / CSV.jl

Utility library for working with CSV and other delimited files in the Julia programming language
https://csv.juliadata.org/
Other
459 stars 141 forks source link

fix typos #1119

Closed musvaage closed 6 months ago

musvaage commented 6 months ago

Should the comment read The or These?

$ ed -s CSV.jl/src/file.jl <<<'567,575p'
        if !ctx.threaded && ctx.ntasks > 1 && !ctx.silencewarnings
            # !ctx.threaded && ctx.ntasks > 1 indicate that multithreaded parsing failed.
            # Thes messages echo the corresponding debug statement in the definition of ctx
            if numwarnings[] > 0
                @warn "Multithreaded parsing failed and fell back to single-threaded parsing, check previous warnings for possible reasons."
            else
                @error "Multithreaded parsing failed and fell back to single-threaded parsing. This can happen if the input contains multi-line fields; otherwise, please report this issue."
            end
        end
$ 

This looks like it should read partition.

$ ed -s CSV.jl/test/write.jl <<<'345,350p'
    # parition writing
    io = IOBuffer()
    io2 = IOBuffer()
    CSV.write([io, io2], Tables.partitioner((default_table, default_table)); partition=true)
    @test String(take!(io)) == "col1,col2,col3\n1,4,7\n2,5,8\n3,6,9\n"
    @test String(take!(io2)) == "col1,col2,col3\n1,4,7\n2,5,8\n3,6,9\n"
$

@nickrobinson251

What is a cscv file?

$ find CSV.jl/test/testfiles -type f | grep -oE '\.(\w+)$' | sort -u
.cscv
.csv
.dat
.gz
.tsv
.txt
.wsv
$ 
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cb1b411) 90.45% compared to head (32c7de7) 90.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1119 +/- ## ========================================== - Coverage 90.45% 90.45% -0.01% ========================================== Files 9 9 Lines 2305 2304 -1 ========================================== - Hits 2085 2084 -1 Misses 220 220 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

quinnj commented 6 months ago

Should the comment read The or These?

These.

This looks like it should read partition.

Correct.

I think .cscv is just a mistake and can be fixed. Thanks!

musvaage commented 6 months ago

I think .cscv is just a mistake and can be fixed.

The cscv file appears to be a duplicate so it was removed.

$ diff test/testfiles/test_one_row_of_data.cscv \
> test/testfiles/test_one_row_of_data.csv
$