search

JuliaData / CSV.jl

Utility library for working with CSV and other delimited files in the Julia programming language
https://csv.juliadata.org/
Other
470 stars 140 forks source link

support for IOBuffer containing `Memory` #1125

Closed longemen3000 closed 7 months ago

longemen3000 commented 7 months ago

tries to fix #1124

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.25%. Comparing base (66a3a65) to head (ea8796f).

Files Patch % Lines
src/utils.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1125 +/- ## ========================================== - Coverage 90.41% 90.25% -0.17% ========================================== Files 9 9 Lines 2305 2308 +3 ========================================== - Hits 2084 2083 -1 - Misses 221 225 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

longemen3000 commented 7 months ago

The good news is that the library prrcompiles on nightly, the bad news is that it fails 😅. I'm gonna check what is wrong

longemen3000 commented 7 months ago

@ViralBShah the tests now pass on nightly. the doc errors are due to Documenter 1.0 strict setting. another PR for that is coming.

ViralBShah commented 7 months ago

@oscardssmith Is this good to merge (since you brought this to my attention)?

oscardssmith commented 7 months ago

It looks reasonable to me. The entire getbytebuffer should probably be removed entirely since it's a function who's whole purpose is to violate the IOBuffer abstraction, but within the current framework, this seems like a good fix.

ViralBShah commented 7 months ago

I'll merge for now to fix the breakage elsewhere.

KristofferC commented 7 months ago

Needs a new version for breakage to be fixed.

quinnj commented 7 months ago

I've kicked off a new release