search

JuliaData / CSV.jl

Utility library for working with CSV and other delimited files in the Julia programming language
https://csv.juliadata.org/
Other
470 stars 140 forks source link

Fix breakage caused by JuliaLang/julia/pull/53896 #1133

Closed longemen3000 closed 5 months ago

longemen3000 commented 5 months ago

https://github.com/JuliaLang/julia/pull/53896 removed Base.wrap, and i did use that to fix CSV in the last patch. This now uses view(x::Memory,len) instead.

fixes #1132

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.41%. Comparing base (acd36a6) to head (eafb38b).

Files Patch % Lines
src/utils.jl 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1133 +/- ## ========================================== + Coverage 90.12% 90.41% +0.29% ========================================== Files 9 9 Lines 2309 2338 +29 ========================================== + Hits 2081 2114 +33 + Misses 228 224 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Keno commented 5 months ago

I'd like to go ahead and merge this to fix the regression on master. If there's additional simplification to be had, let's do a follow up PR.

ViralBShah commented 5 months ago

I'm merging to fix the breakage - and perhaps further improvements can follow.