droplevels!(): more efficient implementation

JuliaData / CategoricalArrays.jl

Arrays for working with categorical data (both nominal and ordinal)

Other

125 stars 33 forks source link

droplevels!(): more efficient implementation #359

Closed alyst closed 3 years ago

alyst commented 3 years ago

Replace the current one-line implementation of droplevels!() as behind the scenes it requires sorting and arrays intersection. The new implementation scans the array only once, and doesn't rebuild the array when all levels are observed.

alyst commented 3 years ago

do you think it is ready to be merged?

bkamins commented 3 years ago

We might need to wait a bit as @nalimilan is OOO AFAICT.

alyst commented 3 years ago

gentle bump

nalimilan commented 3 years ago

Feel free to merge PRs that I have approved (three times!). :-)