JuliaData / CategoricalArrays.jl

Arrays for working with categorical data (both nominal and ordinal)
Other
125 stars 33 forks source link

Drop redundant `convert(Union{T, Missing/Nothing}, x)` methods #396

Closed nalimilan closed 2 years ago

nalimilan commented 2 years ago

The fallback defined in Base calls convert(T, x), giving the same result, and these methods cause invalidations.

nalimilan commented 2 years ago

Actually it seems it was only tested indirectly. I've added tests.

nalimilan commented 2 years ago

https://github.com/JuliaRegistries/General/pull/68941