search

JuliaData / DBFTables.jl

Read and write DBF (dBase) tabular data in Julia
Other
10 stars 11 forks source link

add methods for length and size of Row #13

Closed visr closed 3 years ago

visr commented 3 years ago

Useful for https://github.com/JuliaGeo/Shapefile.jl/issues/50.

quinnj commented 3 years ago

To make this a little more robust, I think we should have struct Row <: Tables.AbstractRow. Then we get length, getproperty, getindex, etc. all for free. The other changes needed then is to switch from defining propertynames, getproperty to defining Tables.columnnames and Tables.getcolumn. If you're up for that, it'd be a great improvement. I can also do it if you'd rather.

visr commented 3 years ago

Ah that sounds good, I wasn't aware of Tables.AbstractRow. I'll try it out in a few days.

quinnj commented 3 years ago

@visr , anything else you wanted to add/change here? It LGTM. Should we merge & tag?

visr commented 3 years ago

Nope, merge and tag would be great!