`Between` should accept more than `Int` and `Symbol`

JuliaData / DataAPI.jl

A data-focused namespace for packages to share functions

Other

33 stars 13 forks source link

`Between` should accept more than `Int` and `Symbol` #21

Closed pdeffebach closed 4 years ago

pdeffebach commented 4 years ago

With the new DataFrames String indexing, Between(a::String, b::String) fails due to the type constraint in Between here.

My understanding is that DataAPI doesn't need to enforce exactly the type signature in this context. It's enough that functions live here to avoid type piracy.

pdeffebach commented 4 years ago

Closing this, since I didn't realize it was added in master. Nevermind! DataFrames master currently doesn't pull in DataAPI master, which is what's causing the issue.

bkamins commented 4 years ago

DataFrames master depends on DataAPI.jl v 1.2 which defines it.