search

JuliaData / DataFrames.jl

In-memory tabular data in Julia
https://dataframes.juliadata.org/stable/
Other
1.73k stars 367 forks source link

Replace replace with a comprehension #1713

Open bkamins opened 5 years ago

bkamins commented 5 years ago

See https://github.com/JuliaData/DataFrames.jl/pull/1709#discussion_r253771079. This should be changed when https://github.com/JuliaLang/julia/pull/30485 is fixed.

bkamins commented 5 years ago

@nalimilan Given JuliaLang/julia#30485 maybe we should drop 1.0 milestone here?

nalimilan commented 5 years ago

Let's see whether we can make progress on that issue. I've pinged Jameson.

bkamins commented 1 year ago

@nalimilan now this can be fixed but it would produce the following union in inference:

Union{Vector{Missing}, Vector{Union{Missing, Int}}, Vector{Int}}

(but indeed if Vector{Int} is produced, which is most common, it would be faster)

Are we OK with this and make the change?