dgkf
commented
4 years ago I'd be happy to take this on to get introduced to the codebase. Just to round out some test cases before jumping into this, it appears to be an issue primarily with extra long cell contents (as in the original example)
julia> io = IOContext(IOBuffer(), :displaysize=>(100,20), :limit=>true)
julia> function fake_show(io, args...; kwargs...)
show(io, args...; kwargs...)
print(String(take!(io.io)))
end
julia> fake_show(io, DataFrame(x = "a" ^ 10), allcols=true) # limit of width
1×1 DataFrame
│ Row │ x │
│ │ String │
├─────┼─────────────┤
│ 1 │ aaaaaaaaaaa │
julia> fake_show(io, DataFrame(x = "a" ^ 11), allcols=true) # overflows width
1×1 DataFrame
│ Row │ │ │ ├─────┼
│ 1 │
│ Row │ x │
│ │ String │
├─────┼─────────────┤
│ 1 │ aaaaaaaaaaa │but can also be caused by the Type in the header
julia> io = IOContext(IOBuffer(), :displaysize=>(100,15), :limit=>true)
julia> fake_show(io, DataFrame(x = Union{Real,String}[1, "a"]), allcols=true)
2×1 DataFrame
│ Row │ │ │ ├─────┼
│ 1 │ │ 2 │
│ Row │ x │
│ │ Union… │
├─────┼────────┤
│ 1 │ 1 │
│ 2 │ a │or by long column names
julia> fake_show(io, DataFrame(abcdefg = [1, 2]), allcols = true)
2×1 DataFrame
│ Row │ │ │ ├─────┼
│ 1 │ │ 2 │
│ Row │ abcdefg │
│ │ Int64 │
├─────┼─────────┤
│ 1 │ 1 │
│ 2 │ 2 │Option 1: truncation
julia> <fixed show option 1>(io, DataFrame(x = "a" ^ 11), allcols=true)
1×1 DataFrame
│ Row │ x │
│ │ String │ # ideally with "\e[90m…\e[39m" colored text
├─────┼─────────────┤ # similar to header type, to disambiguate from an
│ 1 │ aaaaaaaaaa… │ # actual part of the stringOption 2: wrapping output that can't fit within display width
julia> <fixed show option 2>(io, DataFrame(x = "a" ^ 11), allcols=true)
1×1 DataFrame
│ Row │ x │
│ │ String │
├─────┼─────────────┤
│ 1 │ aaaaaaaaaaa │ # overflow to multi-line rows
│ │ a │Handling extreme cases:
It should probably just print out a message that the display width needs to increase if there's less than or equal to only enough space for a single character from a single column to print. Something like:
1x1 | # 6 char display size
DataFr|
ame |
displa| # use "\e[90m…\e[39m" colored text for "display too narrow" text
y |
too |
narrow|If the goal is to get something cleaner worked out as quickly as possible, I'd be inclined to do option 1, but if faithfulness to showing all cell show output is a priority then perhaps that would break this goal and option 2 would be preferred. I could definitely see text wrapping being helpful for things like paragraphs of text in a single cell, but it seems like a pretty niche use case.
Proposal:
Go with option 1, truncate column names, header Types and cell text down to a minimum of 1 visible character and an ellipsis (always displayed in faded font), displaying a message to increase display size for anything narrower than that.
bkamins
@nalimilan - I understand that you are working on making
showof a data frame in REPL more slick. Here is a corner case to test against (currently it is not rendered very nicely):