search

JuliaData / DataTables.jl

(DEPRECATED) A rewrite of DataFrames.jl based on Nullable
Other
29 stars 11 forks source link

adjust outer join behavior (types and right outer join bug) #44

Closed cjprybol closed 7 years ago

cjprybol commented 7 years ago

Separated from #30 as part of a PR refactor. Fixes a bug found in https://github.com/JuliaData/DataTables.jl/issues/34#issuecomment-287203032. Also fixes the issue that in the current implementation, resize! has the ability to introduce #undef values where Nullables should be placed.

nalimilan commented 7 years ago

Thanks. The commit message should explain what the fixed bug was. Also, I don't think this really "type-stabilizes" join, it just avoid returning #undef entries by making them null entries of a nullable array.

cjprybol commented 7 years ago

FIXME removed and determining the offset has been cleaned up.

cjprybol commented 7 years ago

Didn't see anything in the coverage drop that looks related.

nalimilan commented 7 years ago

Thanks! Out of curiosity, have you checked whether the new code is measurably faster than the old one?

cjprybol commented 7 years ago

Thanks here too! I don't remember benchmarking any of these changes, but let's save runtime testing for after https://github.com/JuliaData/DataTables.jl/issues/62.