Closed cjprybol closed 7 years ago
Thanks. The commit message should explain what the fixed bug was. Also, I don't think this really "type-stabilizes" join
, it just avoid returning #undef
entries by making them null entries of a nullable array.
FIXME removed and determining the offset has been cleaned up.
Didn't see anything in the coverage drop that looks related.
Thanks! Out of curiosity, have you checked whether the new code is measurably faster than the old one?
Thanks here too! I don't remember benchmarking any of these changes, but let's save runtime testing for after https://github.com/JuliaData/DataTables.jl/issues/62.
Separated from #30 as part of a PR refactor. Fixes a bug found in https://github.com/JuliaData/DataTables.jl/issues/34#issuecomment-287203032. Also fixes the issue that in the current implementation,
resize!
has the ability to introduce#undef
values whereNullable
s should be placed.