Stack should use similar_nullable, not NullableArray

JuliaData / DataTables.jl

(DEPRECATED) A rewrite of DataFrames.jl based on Nullable

Other

29 stars 11 forks source link

Stack should use similar_nullable, not NullableArray #54

Closed cjprybol closed 7 years ago

cjprybol commented 7 years ago

Adds a test set to trigger multiple entries in unstack warning
Adds a similar_nullable function for NullableCategoricalArrays
Tests to make sure column types are converted to their appropriate nullable type.

cjprybol commented 7 years ago

Updated. I tagged on a commit at the end to fix the deprecation warnings for similar_nullable as the new tests triggered the depwarn.

ararslan commented 7 years ago

On 0.6 you can test warnings with @test_warn (IIRC). That may have been ported to BaseTestNext, in which case you could use that.

cjprybol commented 7 years ago

Thanks for the suggestion, Alex! Didn't know about @test_warn and @test_nowarn, but I'm glad they are in 0.6! I've updated the tests to check if those macros are defined and if so, the warnings are checked. Let's see if the CI tests for 0.5 complain or if that will work.

I couldn't find anything in BaseTestNext or compat to extend supporting those macros into v0.5