Closed mpastell closed 7 years ago
Is the StatsBase dependency even still relevant for this package? It is for DataFrames since that still has the modeling functionality, but AFAICT there's nothing here that needs it. (I may well be missing something though.)
I think it's only needed for StatsBase.describe
, the rest of the package doesn't need to be exported. But it seems that using StatsBase
, adding methods with StatsBase.describe = ...
, and exporting it by name via export describe
works just fine. At least that's what the tests say in https://github.com/JuliaData/DataTables.jl/issues/59
Ah yes, I had forgotten about describe
. I guess we do still need it then.
Fixed by #59.
Thanks! That was fast!
Would it be possible to not reexport Statsbase? I often use DataTables (and DataFrames) without using Statsbase.
I think the reexport is not intuitive and having
fit
andpredict
exported is annoying when using DataTables with ScikitLearn.jl . Also DataTables exporting things likeautocor
is a bit weird.