search

JuliaData / DataTables.jl

(DEPRECATED) A rewrite of DataFrames.jl based on Nullable
Other
29 stars 11 forks source link

Get PR 66 passing tests on Julia 0.7 #83

Closed cjprybol closed 7 years ago

cjprybol commented 7 years ago

Batch/Row -> Field/Column Update CategoricalArray tests remove references to Nullables and NullableArrays Add check for whether Base.unique! is defined (0.6 vs. 0.7) Update StatsBase.describe code to work with Nulls Update documentation and examples for working with nulls

This is passing for me locally using @nalimilan's https://github.com/JuliaData/CategoricalArrays.jl/pull/70 and @quinnj's null branch on DataStreams. Note this PR is targetted to merge into @quinnj's branch under review in #66 rather than master so we don't lose track of the things we haven't addressed yet in that PR

cjprybol commented 7 years ago

Ok, I think I've taken care of all of the ?T references. Thanks for the reviews @nalimilan!

~Looks like the only failures left are from the same sorting issue noted by @rofinn in the nulls Categorical Array PR https://github.com/JuliaData/CategoricalArrays.jl/pull/70#issuecomment-324731167.~ https://github.com/JuliaData/CategoricalArrays.jl/pull/76

nalimilan commented 7 years ago

@quinnj Can we merge this into #66? That would make it easier to review the final PR.

quinnj commented 7 years ago

Yes please, feel free to run w/ this & that PR. I'm tied up with some other DataStreams tagging issues currently.

nalimilan commented 7 years ago

@cjprybol Merge if you think it's ready enough. Then we can add the missing pieces directly to #66.