search

JuliaData / DataTables.jl

(DEPRECATED) A rewrite of DataFrames.jl based on Nullable
Other
29 stars 11 forks source link

Fix Julia 0.6 deprecations #9

Closed nalimilan closed 7 years ago

nalimilan commented 7 years ago

Remaining warnings come from NullableArrays (and are fixed on its master branch).

nalimilan commented 7 years ago

Tests passed on 0.5.

cjprybol commented 7 years ago

👍

nalimilan commented 7 years ago

OK to merge?

@andreasnoack The change to compute reserved words should be useful for your PR (adapting the list is not enough).

andreasnoack commented 7 years ago

Yes. I saw your fancy regex and plan to steal it. It is much better than the hack I implemented.

nalimilan commented 7 years ago

Actually, I had forgotten I made a PR for it: https://github.com/JuliaStats/DataFrames.jl/pull/1165.