search

JuliaData / Feather.jl

Read and write feather files in pure Julia
https://juliadata.github.io/Feather.jl/stable
Other
109 stars 27 forks source link

Fix bug in Data.isdone and Data.getfield #14

Closed davidanthoff closed 8 years ago

davidanthoff commented 8 years ago

Both of these were triggered when I use Query.jl with a feather source. Would be great if you could merge this and then tag a new release.

quinnj commented 8 years ago

Sorry for the weird state, I'm actually shuffling things around in DataStreams, but haven't pushed some updates. I'm waiting on a few CategoricalArray fixes and then I'll push everything and re-tag.

davidanthoff commented 8 years ago

Sure, sounds good!

davidanthoff commented 8 years ago

@quinnj I just saw that you fixed one of the bugs in this original PR on master already. So now this PR only has a fix for the other, remaining, error. I think this right now is the only bug that is preventing Query.jl from working with a feather data source.

codecov-io commented 8 years ago

Current coverage is 69.70% (diff: 100%)

Merging #14 into master will not change coverage

@@             master        #14   diff @@
==========================================
  Files             3          3          
  Lines           241        241          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            168        168          
  Misses           73         73          
  Partials          0          0

Powered by Codecov. Last update 97bc8ca...c306e9e

quinnj commented 8 years ago

hey @davidanthoff, sorry for the delay here. I started looking into it and it turns out I had several Data.isdone definitions that weren't quite right across the datastream ecosystem. I've corrected them all locally (including Feather.jl), and I'm going to do a few more rounds of testing between the various packages to ensure everything is ship-shape. I'll try and get a new tag out for all the packages sometime next week.

davidanthoff commented 8 years ago

Ok, cool. I just tested Feather master with Query, and it all seems to work now! As soon as you have tagged a new version, I'll add tests to Query for this scenario.