JuliaData / Feather.jl

Read and write feather files in pure Julia
https://juliadata.github.io/Feather.jl/stable
Other
109 stars 27 forks source link

Doesn't load on julia 0.6 #58

Closed davidanthoff closed 6 years ago

davidanthoff commented 6 years ago

This is what I get on julia 0.6 right now:

julia> using Feather
WARNING: Method definition ==(Base.Nullable{S}, Base.Nullable{T}) in module Base at nullable.jl:238 overwritten in module NullableArrays at C:\Users\david\.julia\v0.6\NullableArrays\src\operators.jl:99.
ERROR: LoadError: LoadError: ArgumentError: 2nd argument must be a tuple of types like `(T1,T2,...)`
Stacktrace:
 [1] include_from_node1(::String) at .\loading.jl:569
 [2] include(::String) at .\sysimg.jl:14
 [3] include_from_node1(::String) at .\loading.jl:569
 [4] eval(::Module, ::Any) at .\boot.jl:235
 [5] _require(::Symbol) at .\loading.jl:483
 [6] require(::Symbol) at .\loading.jl:398
while loading C:\Users\david\.julia\v0.6\Feather\src\metadata.jl, in expression starting on line 44
while loading C:\Users\david\.julia\v0.6\Feather\src\Feather.jl, in expression starting on line 21

I think something in the recent FlatBuffers updates broke things. If I fix FlatBuffers at v0.2.0, things seem to work.

Should we maybe as a short-term solution just put upper bounds on FlatBuffers for all the registered versions of Feather.jl in METADATA.jl?

xiaodaigh commented 6 years ago

Got the same error.

Not sure how do to fix FlatBufffers? Can't seem to find resources on initial google so have aksed on stackoverflow

https://stackoverflow.com/questions/47087509/julia-how-i-fix-a-package-at-a-particular-version

swt30 commented 6 years ago

Works on Feather master (with DataFrames master)

quinnj commented 6 years ago

Should be fine now on 0.6 w/ the new Metadata upper bounds.