JuliaData / Feather.jl

Read and write feather files in pure Julia
https://juliadata.github.io/Feather.jl/stable
Other
109 stars 27 forks source link

code reorganization (preparation for Arrow implementation) #73

Closed ExpandingMan closed 6 years ago

ExpandingMan commented 6 years ago

I have reorganized the source code in preparation of rewriting Feather based on an underlying Arrow implementation.

Substantive Changes

Formatting Changes

Let me know if this seems acceptable.

ExpandingMan commented 6 years ago

Looks like tests are getting another method ambiguity error. Will look into this tomorrow.

ExpandingMan commented 6 years ago

I had accidentally left out some type assertions. Should be fine now.

Looks good on 0.6 on Linux. Mac build is hanging for some reason.

ExpandingMan commented 6 years ago

This may be sort of a moot point as Feather will pretty much have to be completely re-written with Arrow fully implemented. See #72 and my progress here.

ExpandingMan commented 6 years ago

This is no longer relevant. See my PR #78.