JuliaData / Feather.jl

Read and write feather files in pure Julia
https://juliadata.github.io/Feather.jl/stable
Other
109 stars 27 forks source link

v0.4.0 not in metadata #88

Closed Rudi79 closed 6 years ago

Rudi79 commented 6 years ago

Hi, First let me thank you for your awesome work. Is it intentionally that the newest release (v0.4.0) is not in metadata? Best, Rudi

ExpandingMan commented 6 years ago

Sorry for the inconvenience. There are problems with the tests on 32-bit Windows, see here. There seems to be some kind of alignment error happening in 32-bit, and to be honest I'm quite stumped about how that can occur. To make matters worse, it's going to be very difficult for me to troubleshoot since I only run 64-bit linux.

To be honest, if it were up to me we'd merge it and not maintain windows, but I'm not the only maintainer, and it's not really fair to ignore windows simply because I don't like it (and, to be fair, at this point it's not even clear that the remaining error has anything to do with Windows rather than just the word size).

Help with the remaining issue is extremely welcome.

In the meantime, you can definitely do dev Feather and everything should work perfectly fine on 64-bit linux (64-bit windows is also passing now). I use this package literally every day and find it to be quite stable.

Rudi79 commented 6 years ago

Thank you for the quick reply. We use your package also on a daily basis. We use it on linux, mac, win7 and win10. But none of the machines are 32 bit. So unfortunately I can't help on that. But I can confirm the stability on the other systems.

It is just a minor inconvenience. Using add Feather#master makes it harder to have the same set of versions across machines.

It was more out of curiosity why the version was tagged but not on metadata. To be honest, I did not saw the travis result and with the recent changes to Pkg it could have just been my own stupidity.

Anyway, thanks for your work and I'll just wait until things are settled.

ExpandingMan commented 6 years ago

Well, the METADATA PR is now merged. I'm not sure why, I didn't tell them to do it. @quinnj , did you tell them to merge it?

I'm more than happy for this to be properly tagged. I'm going to close this issue and open one about the alignment problem.