search

JuliaData / FlatBuffers.jl

A pure Julia implementation of google flatbuffers
https://juliadata.github.io/FlatBuffers.jl/stable
Other
43 stars 14 forks source link

don't use Pkg.dir #16

Closed tkelman closed 8 years ago

tkelman commented 8 years ago

that prevents the package from passing its tests if installed anywhere else if this wasn't just calling include, you could use dirname(@__FILE__) instead

quinnj commented 8 years ago

Hmmm...I guess I didn't realize that include was always relative to the file that was doing the including? Anyway, this is mainly a convenience when developing since both the fix above and @__FILE__ don't work when running things line-by-line. Also, what are the use cases for using the package outside of where it regularly gets installed? I don't think I've ever thought of that use-case.

tkelman commented 8 years ago

Also, what are the use cases for using the package outside of where it regularly gets installed?

Package bundling.

quinnj commented 8 years ago

what is that?

tkelman commented 8 years ago

Shipping a version of Julia that includes packages preinstalled.

quinnj commented 8 years ago

Are people already doing that? I guess I've just never heard of anyone doing that yet.

tkelman commented 8 years ago

Yes.