search

JuliaData / FlatBuffers.jl

A pure Julia implementation of google flatbuffers
https://juliadata.github.io/FlatBuffers.jl/stable
Other
43 stars 14 forks source link

remove cruft, get tests passing on 1.0 #30

Closed visr closed 6 years ago

visr commented 6 years ago

Please have a good look at the change in macros.jl, because I don't fully get what is happening there, and why this works. I would think __module__ needs to be replaced by @__MODULE__, but this breaks the tests.

codecov[bot] commented 6 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   97.99%   97.91%   -0.08%     
==========================================
  Files           3        3              
  Lines         299      288      -11     
==========================================
- Hits          293      282      -11     
  Misses          6        6
Impacted Files Coverage Δ
src/internals.jl 97.22% <ø> (-0.17%) :arrow_down:
src/FlatBuffers.jl 100% <100%> (ø) :arrow_up:
src/macros.jl 95.65% <100%> (-0.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5b9d6c...d8ee27a. Read the comment docs.

quinnj commented 6 years ago

Thanks! Sorry for the slow review here!