Closed visr closed 6 years ago
Merging #30 into master will decrease coverage by
0.07%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 97.99% 97.91% -0.08%
==========================================
Files 3 3
Lines 299 288 -11
==========================================
- Hits 293 282 -11
Misses 6 6
Impacted Files | Coverage Δ | |
---|---|---|
src/internals.jl | 97.22% <ø> (-0.17%) |
:arrow_down: |
src/FlatBuffers.jl | 100% <100%> (ø) |
:arrow_up: |
src/macros.jl | 95.65% <100%> (-0.07%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5b9d6c...d8ee27a. Read the comment docs.
Thanks! Sorry for the slow review here!
Please have a good look at the change in
macros.jl
, because I don't fully get what is happening there, and why this works. I would think__module__
needs to be replaced by@__MODULE__
, but this breaks the tests.