JuliaData / FlatBuffers.jl

A pure Julia implementation of google flatbuffers
https://juliadata.github.io/FlatBuffers.jl/stable
Other
43 stars 14 forks source link

flatc support #33

Closed rjkat closed 5 years ago

rjkat commented 6 years ago
codecov[bot] commented 6 years ago

Codecov Report

Merging #33 into master will increase coverage by 11.31%. The diff coverage is 79.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
+ Coverage   68.61%   79.93%   +11.31%     
===========================================
  Files           3        3               
  Lines         411      573      +162     
===========================================
+ Hits          282      458      +176     
+ Misses        129      115       -14
Impacted Files Coverage Δ
src/macros.jl 77.77% <76.66%> (+3.62%) :arrow_up:
src/FlatBuffers.jl 79.51% <78.37%> (+13.64%) :arrow_up:
src/internals.jl 82.38% <87.69%> (+14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7022926...32876dc. Read the comment docs.

rjkat commented 5 years ago

Looks like a lot of the coverage changes are bogus (in lines that I haven't touched). Not sure how to go about fixing this, will investigate.

rjkat commented 5 years ago

Okay! The code coverage reports on master were indeed bogus. This is ready to merge, pending your approval @quinnj