search

JuliaData / IndexedTables.jl

Flexible tables with ordered indices
https://juliadb.org
MIT License
121 stars 37 forks source link

add join iterator #283

Closed piever closed 3 years ago

piever commented 3 years ago

This moves an iterator that is only needed in IndexedTables from StructArrays. It is essentially a lazy join done via a merge sort between sorted iterators.

I'm planning to remove it from StructArrays in the next breaking release (see https://github.com/JuliaArrays/StructArrays.jl/pull/166), so I'm making this PR to make the update (from StructArrays 0.4 to 0.5) easier for IndexedTables.

On my machine I get some error during testing about WeakRefStrings, but they seem unrelated. (EDIT: never mind, CI passes here, I must have some dependencies devved locally.)

codecov[bot] commented 3 years ago

Codecov Report

Merging #283 (f7a963f) into main (0dcef2d) will increase coverage by 0.17%. The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   85.76%   85.93%   +0.17%     
==========================================
  Files          15       15              
  Lines        1510     1543      +33     
==========================================
+ Hits         1295     1326      +31     
- Misses        215      217       +2
Impacted Files Coverage Δ
src/IndexedTables.jl 83.33% <ø> (ø)
src/join.jl 92.60% <93.93%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0dcef2d...f7a963f. Read the comment docs.