JuliaData / JSONTables.jl

JSON3.jl + Tables.jl
MIT License
68 stars 10 forks source link

jsontable(x::AbstractVector{<:JSON3.Object}) #23

Open anandijain opened 2 years ago

anandijain commented 2 years ago

@quinnj

This PR making me realize I'm bad at type parameters, I think we still want the jsontable(x::JSON3.Array) dispatch that I commented out.

Should I make it jsontable(x::JSON3.Array{Any}) or something?

Thanks

quinnj commented 2 years ago

I think just uncommenting it should be fine? Were you seeing issues not specifying a type paramter?

codecov[bot] commented 2 years ago

Codecov Report

Base: 91.57% // Head: 92.55% // Increases project coverage by +0.97% :tada:

Coverage data is based on head (c6fac42) compared to base (239f4f2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 91.57% 92.55% +0.97% ========================================== Files 1 1 Lines 95 94 -1 ========================================== Hits 87 87 + Misses 8 7 -1 ``` | [Impacted Files](https://codecov.io/gh/JuliaData/JSONTables.jl/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData) | Coverage Δ | | |---|---|---| | [src/JSONTables.jl](https://codecov.io/gh/JuliaData/JSONTables.jl/pull/23/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData#diff-c3JjL0pTT05UYWJsZXMuamw=) | `92.55% <100.00%> (+0.97%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.