Handle additional non-bitstypes unions

JuliaData / MemPool.jl

High-performance parallel and distributed datastore for Julia

Other

23 stars 15 forks source link

Handle additional non-bitstypes unions #44

Closed MichaelHatherly closed 3 years ago

MichaelHatherly commented 4 years ago

Fixes #43. I'm not too familiar with this code, so not 100% sure this is a suitable fix. Tests pass locally with this change, so maybe.

shashi commented 4 years ago

looks good! maybe a test will keep it working?

MichaelHatherly commented 4 years ago

maybe a test will keep it working?

Added a more direct test in addition to the roundtrip one.

MichaelHatherly commented 4 years ago

Anything else need done here @shashi? Windows failures unrelated.

MichaelHatherly commented 3 years ago

Bump?

jpsamaroo commented 3 years ago

Thanks!

MichaelHatherly commented 3 years ago

@jpsamaroo, any chance we could get a new patch release containing this fix?

jpsamaroo commented 3 years ago

I'd like to do that, but right now we're having issues with DRef refcounting being broken-ish. I'm trying to get #45 finished up (95% done) so that MemPool is robust. If I don't merge and register by the end of next week, please ping me again and I'll merge #45 as-is anyway.

jpsamaroo commented 3 years ago

Ok, MemPool 0.3.3 will be released in the next few minutes.

MichaelHatherly commented 3 years ago

Thanks @jpsamaroo.