search

JuliaData / MemPool.jl

High-performance parallel and distributed datastore for Julia
Other
23 stars 15 forks source link

Fix DRef borrowing #45

Closed jpsamaroo closed 3 years ago

jpsamaroo commented 3 years ago

Still encounters some poolunref called before poolref assertions on large Dagger.DArray operations with many workers, but otherwise I haven't gotten any KeyErrors with this.

jpsamaroo commented 3 years ago

While there is the occasional chance for errors while trying to finalize a DRef, I haven't encountered them recently, and this PR has stopped me from seeing KeyErrors. I'm going to merge this once it passes CI, as I consider it a critical bugfix, but further work will need to be done to improve performance and ensure correctness.