search

JuliaData / MemPool.jl

High-performance parallel and distributed datastore for Julia
Other
23 stars 15 forks source link

MemPool >= 0.3.7 causes errors on Julia < 1.4 #57

Closed mattwigway closed 3 years ago

mattwigway commented 3 years ago

GC.safepoint was added in Julia 1.4. a7f57035d801e8fc722288bbf58dd6435b1cc99d adds a call to GC.safepoint(). Package.toml suggests this package should be compatible with Julia >= 1.0.

I'm not sure why the GC.safepoint() call was added. If it was to increase GC performance, I'd suggest just wrapping it with something like this:

@static if VERSION >= v"1.4"
  GC.safepoint()
end

Otherwise, perhaps Project.toml should be updated to indicate compatibility with only Julia >= 1.4.

(btw, I discovered this working on fixing tests in another package that should support older Julia, I'm not using Julia < 1.4 in production).

jpsamaroo commented 3 years ago

Ahh, whoops. We added this because we got livelocks when a GC pass started but a thread was waiting on a MemPool lock, without yielding to the GC. I would probably just set the Julia compat to 1.4, rather than removing correctness on <1.4.

mattwigway commented 3 years ago

👍 thanks for the quick response!

On Wed, Oct 20, 2021, 10:18 AM Julian Samaroo @.***> wrote:

Closed #57 https://github.com/JuliaData/MemPool.jl/issues/57 via #58 https://github.com/JuliaData/MemPool.jl/pull/58.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaData/MemPool.jl/issues/57#event-5492285441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEKNLTAXQYPGT7KSYAPYWTUH3FTVANCNFSM5GKME27Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.