search

JuliaData / MemPool.jl

High-performance parallel and distributed datastore for Julia
Other
23 stars 15 forks source link

Add a type assertion to remove some invalidations #83

Closed JamesWrigley closed 7 months ago

JamesWrigley commented 7 months ago

This removes about 55 invalidations from Base._any(), which is called by any() which is called by sra_migrate!(). Not sure why storage_read() fails to infer by itself, perhaps because it's using atomics?

Before:

┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬──────────────────┬───────────────┬─────────────────┐                                                     
│ <file name>:<line number>                                                                                                         │  Function Name   │ Invalidations │ Invalidations % │                                                     
│                                                                                                                                   │                  │               │     (xᵢ/∑x)     │                                                     
├───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼──────────────────┼───────────────┼─────────────────┤                                                     
│ /cache/build/builder-amdci5-1/julialang/julia-release-1-dot-10/usr/share/julia/stdlib/v1.10/SparseArrays/src/sparsematrix.jl:2375 │       _any       │      90       │       22        │

After:

┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬──────────────────┬───────────────┬─────────────────┐                                                     
│ <file name>:<line number>                                                                                                         │  Function Name   │ Invalidations │ Invalidations % │                                                     
│                                                                                                                                   │                  │               │     (xᵢ/∑x)     │                                                     
├───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼──────────────────┼───────────────┼─────────────────┤                                                     
│ /cache/build/builder-amdci5-1/julialang/julia-release-1-dot-10/usr/share/julia/stdlib/v1.10/SparseArrays/src/sparsematrix.jl:2375 │       _any       │      35       │       14        │

This is the invalidation tree for this particular invalidation:

julia> show(trees[end].backedges[end]; maxdepth=30, minchildren=0)                                                                                                                                                                             
MethodInstance for Base._any(::MemPool.var"#107#115"{MemPool.SimpleRecencyAllocator}, ::AbstractArray, ::Colon) (36 children)                                                                                                                  
 MethodInstance for Base.var"#any#849"(::Colon, ::typeof(any), ::MemPool.var"#107#115"{MemPool.SimpleRecencyAllocator}, ::AbstractArray) (35 children)                                                                                         
  MethodInstance for any(::MemPool.var"#107#115"{MemPool.SimpleRecencyAllocator}, ::AbstractArray) (34 children)                                                                                                                               
   MethodInstance for MemPool.var"#sra_migrate!#106"(::Bool, ::Bool, ::typeof(MemPool.sra_migrate!), ::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Missing) (0 children)                                                    
   MethodInstance for MemPool.var"#sra_migrate!#106"(::Bool, ::Bool, ::typeof(MemPool.sra_migrate!), ::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Bool) (32 children)                                                      
    MethodInstance for Core.kwcall(::@NamedTuple{read::Bool, locked::Bool}, ::typeof(MemPool.sra_migrate!), ::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Bool) (31 children)                                               
     MethodInstance for (::MemPool.var"#127#130"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (9 children)                                                                                                                      
      MethodInstance for MemPool.with_lock(::MemPool.var"#127#130"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64}, ::MemPool.NonReentrantLock, ::Bool) (8 children)                                                                  
       MethodInstance for MemPool.with_lock(::MemPool.var"#127#130"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64}, ::MemPool.NonReentrantLock) (7 children)                                                                         
        MethodInstance for MemPool.delete_from_device!(::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64) (6 children)                                                                                                             
         MethodInstance for (::MemPool.var"#108#116"{Bool, MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (0 children)                                                                                                            
         MethodInstance for (::MemPool.var"#127#130"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (0 children)                                                                                                                  
         MethodInstance for (::MemPool.var"#201#205"{Int64})() (3 children)                                                                                                                                                                    
          MethodInstance for MemPool.with_lock(::MemPool.var"#201#205"{Int64}, ::MemPool.NonReentrantLock, ::Bool) (2 children)                                                                                                                
           MethodInstance for MemPool.with_lock(::MemPool.var"#201#205"{Int64}, ::MemPool.NonReentrantLock) (1 children)                                                                                                                       
            MethodInstance for MemPool.exit_hook() (0 children)                                                                                                                                                                                
     MethodInstance for (::MemPool.var"#123#125"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64, Bool})() (20 children)                                                                                                               
      MethodInstance for MemPool.write_to_device!(::MemPool.CPURAMDevice, ::MemPool.RefState, ::Int64) (0 children)                                                                                                                            
      MethodInstance for MemPool.with_lock(::MemPool.var"#123#125"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64, Bool}, ::MemPool.NonReentrantLock, ::Bool) (18 children)                                                           
       MethodInstance for MemPool.with_lock(::MemPool.var"#123#125"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64, Bool}, ::MemPool.NonReentrantLock) (17 children)                                                                  
        MethodInstance for MemPool.read_from_device(::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Bool) (16 children)                                                                                                       
         MethodInstance for MemPool.write_to_device!(::MemPool.CPURAMDevice, ::MemPool.RefState, ::Int64) (0 children)                                                                                                                         
         MethodInstance for (::MemPool.var"#108#116"{Bool, MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (0 children)                                                                                                            
         MethodInstance for MemPool.write_to_device!(::MemPool.GenericFileDevice{S, D, F, M}, ::MemPool.RefState, ::Int64) where {S, D, F, M} (0 children)                                                                                     
         MethodInstance for MemPool.read_from_device(::MemPool.CPURAMDevice, ::MemPool.RefState, ::Int64, ::Bool) (12 children)                                                                                                                
          MethodInstance for (::MemPool.var"#123#125"{MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64, Bool})() (0 children)                                                                                                           
          MethodInstance for MemPool.read_from_device(::MemPool.CPURAMDevice, ::MemPool.RefState, ::Int64, ::Bool) (0 children)                                                                                                                
          MethodInstance for (::MemPool.var"#108#116"{Bool, MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (0 children)
          MethodInstance for MemPool.write_to_device!(::MemPool.GenericFileDevice{S, D, F, M}, ::MemPool.RefState, ::Int64) where {S, D, F, M} (0 children)
          MethodInstance for MemPool.write_to_device!(::MemPool.CPURAMDevice, ::MemPool.RefState, ::Int64) (7 children)
           MethodInstance for (::MemPool.var"#108#116"{Bool, MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (6 children)
            MethodInstance for MemPool.with_lock(::MemPool.var"#108#116"{Bool, MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64}, ::MemPool.NonReentrantLock, ::Bool) (5 children)
             MethodInstance for MemPool.var"#sra_migrate!#106"(::Bool, ::Bool, ::typeof(MemPool.sra_migrate!), ::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Bool) (0 children)
             MethodInstance for MemPool.var"#sra_migrate!#106"(::Bool, ::Bool, ::typeof(MemPool.sra_migrate!), ::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Missing) (3 children)
              MethodInstance for MemPool.sra_migrate!(::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64, ::Missing) (2 children)
               MethodInstance for MemPool.write_to_device!(::MemPool.SimpleRecencyAllocator, ::MemPool.RefState, ::Int64) (1 children)
                MethodInstance for (::MemPool.var"#108#116"{Bool, MemPool.SimpleRecencyAllocator, MemPool.RefState, Int64})() (0 children)
jpsamaroo commented 7 months ago

Great find, thanks!