search

JuliaData / SplitApplyCombine.jl

Split-apply-combine strategies for Julia
Other
144 stars 15 forks source link

Fix tests on 1.1 #19

Closed visr closed 5 years ago

visr commented 5 years ago

The first commit fixes the test only, the second one is a bugfix to groupview. Not sure how that was working earlier.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+8.8%) to 67.718% when pulling f832db12685f03148344c16df4c8b26713534b31 on visr:fixtests into d342b50aa1d9c6f30e10495b3b337ac5b53d12e7 on JuliaData:master.

codecov-io commented 5 years ago

Codecov Report

Merging #19 into master will increase coverage by 9.07%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   58.88%   67.95%   +9.07%     
==========================================
  Files          10       10              
  Lines         411      415       +4     
==========================================
+ Hits          242      282      +40     
+ Misses        169      133      -36
Impacted Files Coverage Δ
src/group.jl 60.49% <66.66%> (+11.74%) :arrow_up:
src/map.jl 64.28% <0%> (+3.57%) :arrow_up:
src/innerjoin.jl 54.16% <0%> (+4.16%) :arrow_up:
src/leftgroupjoin.jl 50% <0%> (+6.25%) :arrow_up:
src/product.jl 79.16% <0%> (+8.33%) :arrow_up:
src/splitdims.jl 80.39% <0%> (+8.39%) :arrow_up:
src/invert.jl 79% <0%> (+11.32%) :arrow_up:
src/combinedims.jl 69.56% <0%> (+17.39%) :arrow_up:
src/SplitApplyCombine.jl 50% <0%> (+50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d342b50...f832db1. Read the comment docs.

visr commented 5 years ago

bump

andyferris commented 5 years ago

Sorry I missed this one, @visr! I must have tested this with Ints only - thanks for picking this up.