JuliaData / SplitApplyCombine.jl

Split-apply-combine strategies for Julia
Other
144 stars 15 forks source link

Eliminate `haskey` piracy #47

Closed timholy closed 2 years ago

timholy commented 2 years ago

On nightly, we get this warning:

WARNING: Method definition haskey(Any, Any) in module Base at abstractdict.jl:17 overwritten in module SplitApplyCombine at /home/tim/.julia/packages/SplitApplyCombine/ulZAx/src/SplitApplyCombine.jl:46. incremental compilation may be fatally broken for this module

Make the definition conditional on whether it's already present in Base.

This method was added in https://github.com/JuliaLang/julia/pull/42679. Investigated due to this package triggering PkgEval errors in https://github.com/JuliaLang/julia/pull/43759.

andyferris commented 2 years ago

Thanks @timholy - as always!