search

JuliaData / SplitApplyCombine.jl

Split-apply-combine strategies for Julia
Other
144 stars 15 forks source link

combinedimsview indexing: better performance and no allocations #51

Closed aplavin closed 2 years ago

aplavin commented 2 years ago

Interesting that this has an impact.

Indeed, the @inferred tests missed this inner instability, which actually leads to allocations in getindex since my https://github.com/JuliaData/SplitApplyCombine.jl/pull/45.

I note that the Julia 1.0 test are failing. What has caused that?

I think the @inferred tests have been failing for quite some time already on 1.0. Nothing new here.

andyferris commented 2 years ago

@aplavin I've noticed you've been more active than me here! Thank you - this is appreciated. I have invited you to be a maintainer.