JuliaData / StructTypes.jl

Abstract definitions and convenience methods for describing, processing, and constructing Julia objects
https://juliadata.github.io/StructTypes.jl/stable/
MIT License
80 stars 22 forks source link

Add macro for subtypes lowering with additional `subtypekey` field #94

Closed sairus7 closed 1 year ago

sairus7 commented 1 year ago

Not sure if this API covers all cases, maybe some other key types should be added (now its only Symbol).

closes #93 and https://github.com/quinnj/JSON3.jl/issues/12

quinnj commented 1 year ago

Ah, looks like we have some CI failures; mind taking a look @sairus7?

sairus7 commented 1 year ago

Now it should be working.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.82 :tada:

Comparison is base (4dbad5b) 74.48% compared to head (bff19d2) 75.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #94 +/- ## ========================================== + Coverage 74.48% 75.31% +0.82% ========================================== Files 2 2 Lines 388 401 +13 ========================================== + Hits 289 302 +13 Misses 99 99 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaData/StructTypes.jl/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData) | Coverage Δ | | |---|---|---| | [src/macros.jl](https://app.codecov.io/gh/JuliaData/StructTypes.jl/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData#diff-c3JjL21hY3Jvcy5qbA==) | `95.65% <91.66%> (+4.74%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaData/StructTypes.jl/pull/94/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.