search

JuliaData / TableOperations.jl

Common table operations on Tables.jl interface implementations
Other
46 stars 9 forks source link

Implemented dropmissing functionality #21

Closed TheRoniOne closed 3 years ago

TheRoniOne commented 3 years ago

Attempt to solve #7

Dropping rows with missing values can be seen as a special case of filtering, so I just had to develop a function that handles that case and integrate it with the filter function we already had.

Made some tests to prove all was working as expected and a docstring for the dropmissing function to help keep things clear.

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (be86f52) into main (cfd038f) will increase coverage by 0.71%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   89.90%   90.62%   +0.71%     
==========================================
  Files           1        1              
  Lines         218      224       +6     
==========================================
+ Hits          196      203       +7     
+ Misses         22       21       -1
Impacted Files Coverage Δ
src/TableOperations.jl 90.62% <100.00%> (+0.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfd038f...be86f52. Read the comment docs.

quinnj commented 3 years ago

This looks great! Thanks!