search

JuliaData / TypedTables.jl

Simple, fast, column-based storage for data analysis in Julia
Other
145 stars 25 forks source link

Warnings in Julia v1.9 #108

Open juliohm opened 1 year ago

juliohm commented 1 year ago

Appreciate if you can take a look at these warnings:

WARNING: method definition for broadcasted at C:\Users\julio\.julia\packages\TypedTables\dycVq\src\DictTable.jl:301 declares type variable N but does not use it.
WARNING: method definition for broadcasted at C:\Users\julio\.julia\packages\TypedTables\dycVq\src\DictTable.jl:305 declares type variable N but does not use it.
WARNING: method definition for broadcasted at C:\Users\julio\.julia\packages\TypedTables\dycVq\src\DictTable.jl:309 declares type variable N but does not use it.
WARNING: method definition for broadcasted at C:\Users\julio\.julia\packages\TypedTables\dycVq\src\DictTable.jl:313 declares type variable N but does not use it.
WARNING: method definition for broadcasted at C:\Users\julio\.julia\packages\TypedTables\dycVq\src\DictTable.jl:317 declares type variable N but does not use it.
dmbates commented 1 year ago

Fixed in #107 I think

dmbates commented 1 year ago

Another series of warnings of the form

Test Summary: | Pass  Total  Time
Table         |  119    119  3.2s
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #FlexTable#72 at FlexTable.jl:27 [inlined]
└ @ Core ~/.julia/dev/TypedTables/src/FlexTable.jl:27
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = FlexTable(ts::FlexTable{1}; kwargs::Base.Pairs{Symbol, Vector{Bool}, Tuple{Symbol}, NamedTuple{(:c,), Tuple{Vector{Bool}}}}) at FlexTable.jl:27
└ @ TypedTables ~/.julia/dev/TypedTables/src/FlexTable.jl:27
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = FlexTable(::FlexTable{1}, ::Vararg{Any}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) at FlexTable.jl:27
└ @ TypedTables ~/.julia/dev/TypedTables/src/FlexTable.jl:27
┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = FlexTable(ts::FlexTable{1}; kwargs::Base.Pairs{Symbol, Nothing, Tuple{Symbol}, NamedTuple{(:b,), Tuple{Nothing}}}) at FlexTable.jl:27
└ @ TypedTables ~/.julia/dev/TypedTables/src/FlexTable.jl:27
...

are produced when testing on v1.8.5 and later. I will create a PR to suppress those.