JuliaData / TypedTables.jl

Simple, fast, column-based storage for data analysis in Julia
Other
145 stars 25 forks source link

Replace `kwargs.data` with `values(kwargs)`. #109

Closed dmbates closed 1 year ago

dmbates commented 1 year ago

Per comment in #108

codecov[bot] commented 1 year ago

Codecov Report

Base: 69.08% // Head: 69.12% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (cfdd14e) compared to base (5e69b5a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #109 +/- ## ========================================== + Coverage 69.08% 69.12% +0.03% ========================================== Files 7 7 Lines 909 910 +1 ========================================== + Hits 628 629 +1 Misses 281 281 ``` | [Impacted Files](https://codecov.io/gh/JuliaData/TypedTables.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData) | Coverage Δ | | |---|---|---| | [src/FlexTable.jl](https://codecov.io/gh/JuliaData/TypedTables.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData#diff-c3JjL0ZsZXhUYWJsZS5qbA==) | `80.60% <100.00%> (ø)` | | | [src/TypedTables.jl](https://codecov.io/gh/JuliaData/TypedTables.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData#diff-c3JjL1R5cGVkVGFibGVzLmps) | `90.90% <0.00%> (+0.90%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaData)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dmbates commented 1 year ago

The changes in Project.toml just reorder the lines. I believe this was done automatically by an update of the package with a recent version of Julia. I can revert that file if desired.

I'm not sure about the test failure Julia-v1.0.5. I only tested back to the lts version.