search

JuliaData / TypedTables.jl

Simple, fast, column-based storage for data analysis in Julia
Other
145 stars 25 forks source link

Bump compat for Adapt to 4, (keep existing compat) #113

Closed fhagemann closed 5 months ago

fhagemann commented 6 months ago

Adapt v4.0.0 features breaking changes in Adapt.ndims, Adapt.eltype and Adapt.parent (see https://github.com/JuliaGPU/Adapt.jl/releases/tag/v4.0.0)

TypedTables only seems to be using Adapt.adapt, Adapt.adapt_structure and Adapt.adapt_storage, so it should not be affected by the changes made in Adapt v4.0.0.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d8c8bc9) 68.85% compared to head (2f12602) 69.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== + Coverage 68.85% 69.62% +0.76% ========================================== Files 7 7 Lines 912 912 ========================================== + Hits 628 635 +7 + Misses 284 277 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fhagemann commented 5 months ago

Thanks for merging!