JuliaData / TypedTables.jl

Simple, fast, column-based storage for data analysis in Julia
Other
145 stars 25 forks source link

Resolve warning re use of `kwargs.data` #96

Closed dmbates closed 1 year ago

dmbates commented 1 year ago

In Julia v1.8.0-rc4 creating a DictTable produces a warning of the form

┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #DictTable#117 at DictTable.jl:31 [inlined]
└ @ Core ~/.julia/packages/TypedTables/zfbS2/src/DictTable.jl:31
codecov[bot] commented 1 year ago

Codecov Report

Merging #96 (5e98c60) into main (a7ca98c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files           7        7           
  Lines         909      909           
=======================================
  Hits          633      633           
  Misses        276      276           
Impacted Files Coverage Δ
src/DictTable.jl 57.78% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dmbates commented 1 year ago

I noticed in the testing output that similar changes should be made in lines 27 and 28 of src/FlexTable.jl but I'm not sure if I can add those changes to this PR.

stuartthomas25 commented 1 year ago

There is a similar error in FlexTable.jl