search

JuliaData / YAML.jl

Parse yer YAMLs
Other
125 stars 43 forks source link

Git automatically converts EOL newlines #216

Closed Paalon closed 1 day ago

Paalon commented 1 week ago

Git convert EOL newlines for operating systems perhaps in default. For easy debugging and testing, ~we should prohibit it by setting~.

Complement: it was misleading, I want to say, we should be explicit whether CRLF or LF for input YAML files of our tests.

GunnarFarneback commented 1 week ago

I'm not so sure about that since it would increase the risk that we fail to find Windows specific problems during testing and that they turn up in the wild instead.

Paalon commented 1 week ago

Then, we'll just add tests for the CRLF version of all LF tests.

GunnarFarneback commented 1 week ago

That doesn't sound like a good idea for DRY reasons. I think Windows CI is good enough to capture problems but if we want to run CRLF tests on Linux/Mac, the way to do that is to create CRLF versions of the files on the fly while running the tests.

kescobo commented 6 days ago

related to #232

GunnarFarneback commented 3 days ago

the way to do that is to create CRLF versions of the files on the fly while running the tests.

Implemented in #235.