search

JuliaDataCubes / EarthDataLab.jl

Julia interface for Reading from the Earth System Datacube
http://earthsystemdatacube.net
Other
33 stars 14 forks source link

Make EarthDataLab work for DimDataYAXArrays #298

Closed meggart closed 11 months ago

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 90.00% and project coverage change: -2.41% :warning:

Comparison is base (ed154bf) 55.22% compared to head (e86b0a6) 52.82%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #298 +/- ## ========================================== - Coverage 55.22% 52.82% -2.41% ========================================== Files 12 11 -1 Lines 373 354 -19 ========================================== - Hits 206 187 -19 Misses 167 167 ``` | [Files Changed](https://app.codecov.io/gh/JuliaDataCubes/EarthDataLab.jl/pull/298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes) | Coverage Δ | | |---|---|---| | [src/remap.jl](https://app.codecov.io/gh/JuliaDataCubes/EarthDataLab.jl/pull/298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL3JlbWFwLmps) | `69.09% <75.00%> (ø)` | | | [src/EarthDataLab.jl](https://app.codecov.io/gh/JuliaDataCubes/EarthDataLab.jl/pull/298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0VhcnRoRGF0YUxhYi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/MSC.jl](https://app.codecov.io/gh/JuliaDataCubes/EarthDataLab.jl/pull/298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL01TQy5qbA==) | `99.06% <100.00%> (ø)` | | | [src/Proc.jl](https://app.codecov.io/gh/JuliaDataCubes/EarthDataLab.jl/pull/298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL1Byb2Muamw=) | `100.00% <100.00%> (ø)` | | | [src/esdc.jl](https://app.codecov.io/gh/JuliaDataCubes/EarthDataLab.jl/pull/298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL2VzZGMuamw=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felixcremer commented 12 months ago

Do you have an idea why the CI fails for Julia 1.6? Otherwise this seems to be good to go.

meggart commented 12 months ago

I have no idea. Would it be ok to drop 1.6 support?

meggart commented 12 months ago

On other thing to mention would be that I added and exported these 2:

RangeAxis(name,vals) = DD.Dim{Symbol(name)}(vals)
CategoricalAxis(name,vals) = DD.Dim{Symbol(name)}(vals)

This great;y helped making the tests pass, would it be ok to add these for a few versions even to YAXArrays.jl? Would make working with existing code much simpler, we could also throw a deprecation warning to make sure these don't stay forever.