search

JuliaDataCubes / YAXArrays.jl

Yet Another XArray-like Julia package
https://juliadatacubes.github.io/YAXArrays.jl/
Other
103 stars 18 forks source link

Fix bug when permuting loop axes dimension #201

Closed meggart closed 1 year ago

meggart commented 1 year ago

Fixes #198

github-actions[bot] commented 1 year ago
Benchmark result # Judge result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmarks: - Target: 5 Dec 2022 - 16:50 - Baseline: 5 Dec 2022 - 16:51 * Package commits: - Target: f39bae - Baseline: 617f3a * Julia commits: - Target: 0434de - Baseline: 0434de * Julia command flags: - Target: None - Baseline: None * Environment variables: - Target: None - Baseline: None ## Results A ratio greater than `1.0` denotes a possible regression (marked with :x:), while a ratio less than `1.0` denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds). | ID | time ratio | memory ratio | |--------------------------|------------------------------|------------------------------| | `["mapslices", "small"]` | 0.02 (5%) :white_check_mark: | 0.17 (1%) :white_check_mark: | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ### Target ``` Julia Version 1.8.3 Commit 0434deb161e (2022-11-14 20:14 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 20.04.5 LTS uname: Linux 5.15.0-1023-azure #29~20.04.1-Ubuntu SMP Wed Oct 26 19:18:25 UTC 2022 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: speed user nice sys idle irq #1 2593 MHz 1145 s 1 s 195 s 3883 s 0 s #2 2593 MHz 797 s 2 s 149 s 4253 s 0 s Memory: 6.78125 GB (4673.484375 MB free) Uptime: 526.64 sec Load Avg: 1.34 0.74 0.33 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` ### Baseline ``` Julia Version 1.8.3 Commit 0434deb161e (2022-11-14 20:14 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 20.04.5 LTS uname: Linux 5.15.0-1023-azure #29~20.04.1-Ubuntu SMP Wed Oct 26 19:18:25 UTC 2022 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: speed user nice sys idle irq #1 2593 MHz 1479 s 1 s 208 s 3932 s 0 s #2 2593 MHz 848 s 2 s 151 s 4595 s 0 s Memory: 6.78125 GB (4770.3125 MB free) Uptime: 566.36 sec Load Avg: 1.17 0.77 0.36 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` --- # Target result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmark: 5 Dec 2022 - 16:50 * Package commit: f39bae * Julia commit: 0434de * Julia command flags: None * Environment variables: None ## Results Below is a table of this job's results, obtained by running the benchmarks. The values listed in the `ID` column have the structure `[parent_group, child_group, ..., key]`, and can be used to index into the BaseBenchmarks suite to retrieve the corresponding benchmarks. The percentages accompanying time and memory values in the below table are noise tolerances. The "true" time/memory value for a given benchmark is expected to fall within this percentage of the reported value. An empty cell means that the value was zero. | ID | time | GC time | memory | allocations | |--------------------------|----------------:|---------:|----------------:|------------:| | `["mapslices", "small"]` | 191.046 ms (5%) | 3.787 ms | 326.03 MiB (1%) | 91534 | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ``` Julia Version 1.8.3 Commit 0434deb161e (2022-11-14 20:14 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 20.04.5 LTS uname: Linux 5.15.0-1023-azure #29~20.04.1-Ubuntu SMP Wed Oct 26 19:18:25 UTC 2022 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: speed user nice sys idle irq #1 2593 MHz 1145 s 1 s 195 s 3883 s 0 s #2 2593 MHz 797 s 2 s 149 s 4253 s 0 s Memory: 6.78125 GB (4673.484375 MB free) Uptime: 526.64 sec Load Avg: 1.34 0.74 0.33 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` --- # Baseline result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmark: 5 Dec 2022 - 16:51 * Package commit: 617f3a * Julia commit: 0434de * Julia command flags: None * Environment variables: None ## Results Below is a table of this job's results, obtained by running the benchmarks. The values listed in the `ID` column have the structure `[parent_group, child_group, ..., key]`, and can be used to index into the BaseBenchmarks suite to retrieve the corresponding benchmarks. The percentages accompanying time and memory values in the below table are noise tolerances. The "true" time/memory value for a given benchmark is expected to fall within this percentage of the reported value. An empty cell means that the value was zero. | ID | time | GC time | memory | allocations | |--------------------------|--------------:|-----------:|--------------:|------------:| | `["mapslices", "small"]` | 11.928 s (5%) | 711.236 ms | 1.93 GiB (1%) | 30669730 | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ``` Julia Version 1.8.3 Commit 0434deb161e (2022-11-14 20:14 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 20.04.5 LTS uname: Linux 5.15.0-1023-azure #29~20.04.1-Ubuntu SMP Wed Oct 26 19:18:25 UTC 2022 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: speed user nice sys idle irq #1 2593 MHz 1479 s 1 s 208 s 3932 s 0 s #2 2593 MHz 848 s 2 s 151 s 4595 s 0 s Memory: 6.78125 GB (4770.3125 MB free) Uptime: 566.36 sec Load Avg: 1.17 0.77 0.36 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` --- # Runtime information | Runtime Info | | |:--|:--| | BLAS #threads | 1 | | `BLAS.vendor()` | `openblas64` | | `Sys.CPU_THREADS` | 2 | `lscpu` output: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 46 bits physical, 48 bits virtual CPU(s): 2 On-line CPU(s) list: 0,1 Thread(s) per core: 1 Core(s) per socket: 2 Socket(s): 1 NUMA node(s): 1 Vendor ID: GenuineIntel CPU family: 6 Model: 85 Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz Stepping: 7 CPU MHz: 2593.907 BogoMIPS: 5187.81 Hypervisor vendor: Microsoft Virtualization type: full L1d cache: 64 KiB L1i cache: 64 KiB L2 cache: 2 MiB L3 cache: 35.8 MiB NUMA node0 CPU(s): 0,1 Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported Vulnerability L1tf: Mitigation; PTE Inversion Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown Vulnerability Retbleed: Vulnerable Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear | Cpu Property | Value | |:------------------ |:------------------------------------------------------- | | Brand | Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz | | Vendor | :Intel | | Architecture | :Skylake | | Model | Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00 | | Cores | 2 physical cores, 2 logical cores (on executing CPU) | | | No Hyperthreading hardware capability detected | | Clock Frequencies | Not supported by CPU | | Data Cache | Level 1:3 : (32, 1024, 36608) kbytes | | | 64 byte cache line size | | Address Size | 48 bits virtual, 46 bits physical | | SIMD | 512 bit = 64 byte max. SIMD vector size | | Time Stamp Counter | TSC is accessible via `rdtsc` | | | TSC increased at every clock cycle (non-invariant TSC) | | Perf. Monitoring | Performance Monitoring Counters (PMC) are not supported | | Hypervisor | Yes, Microsoft |
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3622140917

Totals Coverage Status
Change from base Build 3603187089: 0.07%
Covered Lines: 1322
Relevant Lines: 1759
💛 - Coveralls
codecov[bot] commented 1 year ago

Codecov Report

Base: 75.19% // Head: 75.23% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (967d8e9) compared to base (617f3a7). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #201 +/- ## ========================================== + Coverage 75.19% 75.23% +0.04% ========================================== Files 12 12 Lines 1814 1817 +3 ========================================== + Hits 1364 1367 +3 Misses 450 450 ``` | [Impacted Files](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes) | Coverage Δ | | |---|---|---| | [src/DAT/DAT.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/201/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0RBVC9EQVQuamw=) | `74.84% <100.00%> (+0.15%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lazarusA commented 1 year ago

IntegrationTest / EarthDataLab.jl (pull_request)

this test failing is always annoying

do we still need this test? or?