Closed lazarusA closed 1 year ago
this should fix https://github.com/JuliaDataCubes/YAXArrays.jl/issues/223
Totals | |
---|---|
Change from base Build 3844982219: | -0.03% |
Covered Lines: | 1366 |
Relevant Lines: | 1820 |
Base: 75.16% // Head: 75.16% // No change to project coverage :thumbsup:
Coverage data is based on head (
172f77e
) compared to base (34d8d8d
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@felixcremer should we just merge? is a rather small addition.
Isn't the warning to late? We could add sleep(10) to give people time to react. This would add an overhead for people who use overwrite deliberately. I would at least add the warning text to the docstring of savedataset.
add your suggestions here directly, while doing the review. I completely agree with the sleeping part
is 10 seconds enough? But, having https://github.com/JuliaDataCubes/YAXArrays.jl/issues/225 will be the ideal case, then maybe not need for sleep.
@felixcremer done, I think this should be enough. Although, it will be nice to have a description for the other arguments, which in most cases I don't know how to describe them or when to use them 😢 . Maybe you could add those changes as suggestions.
adds warning when using
overwrite=true