search

JuliaDataCubes / YAXArrays.jl

Yet Another XArray-like Julia package
https://juliadatacubes.github.io/YAXArrays.jl/
Other
101 stars 17 forks source link

Remove DataFrames as a dependency #234

Closed felixcremer closed 1 year ago

felixcremer commented 1 year ago

DataFrames is loaded to bring DataFrame into scope, but then this is not used in registration.jl. I am not sure, whether this is a remnant of some functionality but at the moment it is totally unused and it is a quite big dependency.

This change reduces the overall using time of YAXArrays on my computer from good 9 seconds to roughly 3 seconds.

github-actions[bot] commented 1 year ago
Benchmark result # Judge result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmarks: - Target: 15 Feb 2023 - 22:34 - Baseline: 15 Feb 2023 - 22:36 * Package commits: - Target: 49c2f2 - Baseline: b57575 * Julia commits: - Target: 17cfb8 - Baseline: 17cfb8 * Julia command flags: - Target: None - Baseline: None * Environment variables: - Target: None - Baseline: None ## Results A ratio greater than `1.0` denotes a possible regression (marked with :x:), while a ratio less than `1.0` denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds). | ID | time ratio | memory ratio | |--------------------------|------------------------------|------------------------------| | `["mapslices", "small"]` | 0.01 (5%) :white_check_mark: | 0.16 (1%) :white_check_mark: | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ### Target ``` Julia Version 1.8.5 Commit 17cfb8e65ea (2023-01-08 06:45 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.1 LTS uname: Linux 5.15.0-1031-azure #38-Ubuntu SMP Mon Jan 9 12:49:59 UTC 2023 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: speed user nice sys idle irq #1 2095 MHz 1053 s 0 s 201 s 1570 s 0 s #2 2095 MHz 804 s 0 s 173 s 1831 s 0 s Memory: 6.781219482421875 GB (4647.7890625 MB free) Uptime: 289.38 sec Load Avg: 1.42 0.81 0.34 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` ### Baseline ``` Julia Version 1.8.5 Commit 17cfb8e65ea (2023-01-08 06:45 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.1 LTS uname: Linux 5.15.0-1031-azure #38-Ubuntu SMP Mon Jan 9 12:49:59 UTC 2023 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: speed user nice sys idle irq #1 2095 MHz 1877 s 0 s 233 s 1684 s 0 s #2 2095 MHz 953 s 0 s 188 s 2634 s 0 s Memory: 6.781219482421875 GB (4701.41015625 MB free) Uptime: 386.55 sec Load Avg: 1.12 0.89 0.42 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` --- # Target result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmark: 15 Feb 2023 - 22:34 * Package commit: 49c2f2 * Julia commit: 17cfb8 * Julia command flags: None * Environment variables: None ## Results Below is a table of this job's results, obtained by running the benchmarks. The values listed in the `ID` column have the structure `[parent_group, child_group, ..., key]`, and can be used to index into the BaseBenchmarks suite to retrieve the corresponding benchmarks. The percentages accompanying time and memory values in the below table are noise tolerances. The "true" time/memory value for a given benchmark is expected to fall within this percentage of the reported value. An empty cell means that the value was zero. | ID | time | GC time | memory | allocations | |--------------------------|----------------:|---------:|----------------:|------------:| | `["mapslices", "small"]` | 198.789 ms (5%) | 1.957 ms | 326.03 MiB (1%) | 91534 | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ``` Julia Version 1.8.5 Commit 17cfb8e65ea (2023-01-08 06:45 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.1 LTS uname: Linux 5.15.0-1031-azure #38-Ubuntu SMP Mon Jan 9 12:49:59 UTC 2023 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: speed user nice sys idle irq #1 2095 MHz 1053 s 0 s 201 s 1570 s 0 s #2 2095 MHz 804 s 0 s 173 s 1831 s 0 s Memory: 6.781219482421875 GB (4647.7890625 MB free) Uptime: 289.38 sec Load Avg: 1.42 0.81 0.34 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` --- # Baseline result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmark: 15 Feb 2023 - 22:36 * Package commit: b57575 * Julia commit: 17cfb8 * Julia command flags: None * Environment variables: None ## Results Below is a table of this job's results, obtained by running the benchmarks. The values listed in the `ID` column have the structure `[parent_group, child_group, ..., key]`, and can be used to index into the BaseBenchmarks suite to retrieve the corresponding benchmarks. The percentages accompanying time and memory values in the below table are noise tolerances. The "true" time/memory value for a given benchmark is expected to fall within this percentage of the reported value. An empty cell means that the value was zero. | ID | time | GC time | memory | allocations | |--------------------------|--------------:|-----------:|--------------:|------------:| | `["mapslices", "small"]` | 14.583 s (5%) | 873.671 ms | 1.98 GiB (1%) | 31497557 | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ``` Julia Version 1.8.5 Commit 17cfb8e65ea (2023-01-08 06:45 UTC) Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.1 LTS uname: Linux 5.15.0-1031-azure #38-Ubuntu SMP Mon Jan 9 12:49:59 UTC 2023 x86_64 x86_64 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: speed user nice sys idle irq #1 2095 MHz 1877 s 0 s 233 s 1684 s 0 s #2 2095 MHz 953 s 0 s 188 s 2634 s 0 s Memory: 6.781219482421875 GB (4701.41015625 MB free) Uptime: 386.55 sec Load Avg: 1.12 0.89 0.42 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512) Threads: 1 on 2 virtual cores ``` --- # Runtime information | Runtime Info | | |:--|:--| | BLAS #threads | 1 | | `BLAS.vendor()` | `openblas64` | | `Sys.CPU_THREADS` | 2 | `lscpu` output: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 46 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 2 On-line CPU(s) list: 0,1 Vendor ID: GenuineIntel Model name: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz CPU family: 6 Model: 85 Thread(s) per core: 1 Core(s) per socket: 2 Socket(s): 1 Stepping: 4 BogoMIPS: 4190.15 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear Hypervisor vendor: Microsoft Virtualization type: full L1d cache: 64 KiB (2 instances) L1i cache: 64 KiB (2 instances) L2 cache: 2 MiB (2 instances) L3 cache: 35.8 MiB (1 instance) NUMA node(s): 1 NUMA node0 CPU(s): 0,1 Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported Vulnerability L1tf: Mitigation; PTE Inversion Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown Vulnerability Retbleed: Vulnerable Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown | Cpu Property | Value | |:------------------ |:------------------------------------------------------- | | Brand | Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz | | Vendor | :Intel | | Architecture | :Skylake | | Model | Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00 | | Cores | 2 physical cores, 2 logical cores (on executing CPU) | | | No Hyperthreading hardware capability detected | | Clock Frequencies | Not supported by CPU | | Data Cache | Level 1:3 : (32, 1024, 36608) kbytes | | | 64 byte cache line size | | Address Size | 48 bits virtual, 46 bits physical | | SIMD | 512 bit = 64 byte max. SIMD vector size | | Time Stamp Counter | TSC is accessible via `rdtsc` | | | TSC increased at every clock cycle (non-invariant TSC) | | Perf. Monitoring | Performance Monitoring Counters (PMC) are not supported | | Hypervisor | Yes, Microsoft |
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4188734890

Files with Coverage Reduction New Missed Lines %
src/DAT/dciterators.jl 1 82.02%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 4124119584: 0.0%
Covered Lines: 1323
Relevant Lines: 1762
💛 - Coveralls
codecov[bot] commented 1 year ago

Codecov Report

Base: 75.16% // Head: 75.08% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (75e8703) compared to base (b575757). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #234 +/- ## ========================================== - Coverage 75.16% 75.08% -0.08% ========================================== Files 12 12 Lines 1820 1762 -58 ========================================== - Hits 1368 1323 -45 + Misses 452 439 -13 ``` | [Impacted Files](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes) | Coverage Δ | | |---|---|---| | [src/DAT/registration.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0RBVC9yZWdpc3RyYXRpb24uamw=) | `84.84% <ø> (ø)` | | | [src/DAT/tablestats.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0RBVC90YWJsZXN0YXRzLmps) | `43.58% <0.00%> (-1.19%)` | :arrow_down: | | [src/DAT/dciterators.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0RBVC9kY2l0ZXJhdG9ycy5qbA==) | `82.02% <0.00%> (-0.59%)` | :arrow_down: | | [src/Cubes/Axes.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0N1YmVzL0F4ZXMuamw=) | `82.63% <0.00%> (-0.36%)` | :arrow_down: | | [src/YAXTools.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL1lBWFRvb2xzLmps) | `96.07% <0.00%> (-0.15%)` | :arrow_down: | | [src/DAT/DAT.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0RBVC9EQVQuamw=) | `74.78% <0.00%> (-0.06%)` | :arrow_down: | | [src/DatasetAPI/Datasets.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0RhdGFzZXRBUEkvRGF0YXNldHMuamw=) | `75.67% <0.00%> (+0.12%)` | :arrow_up: | | [src/Cubes/Cubes.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0N1YmVzL0N1YmVzLmps) | `93.45% <0.00%> (+0.30%)` | :arrow_up: | | [src/Cubes/Rechunker.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0N1YmVzL1JlY2h1bmtlci5qbA==) | `88.46% <0.00%> (+1.42%)` | :arrow_up: | | [src/Cubes/TransformedCubes.jl](https://codecov.io/gh/JuliaDataCubes/YAXArrays.jl/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes#diff-c3JjL0N1YmVzL1RyYW5zZm9ybWVkQ3ViZXMuamw=) | `79.41% <0.00%> (+1.63%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaDataCubes)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.