Closed meggart closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/DAT/DAT.jl | 1 | 3 | 33.33% | ||
src/DAT/dciterators.jl | 0 | 4 | 0.0% | ||
<!-- | Total: | 13 | 19 | 68.42% | --> |
Totals | |
---|---|
Change from base Build 5376433093: | 0.5% |
Covered Lines: | 1353 |
Relevant Lines: | 1785 |
Patch coverage: 45.45
% and project coverage change: +0.44
:tada:
Comparison is base (
1d44e97
) 75.34% compared to head (a289f4a
) 75.79%.:exclamation: Current head a289f4a differs from pull request most recent head 4b68f4b. Consider uploading reports for the commit 4b68f4b to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@felixcremer you also mentioned having some issues with memory accumulating in one of your RQA runs. If you find some time, maybe you can try this branch?
Just as a bit of a context, this is the error, that I get, when I do not manually call GC.gc()
With this pull request the computation finishes in 47 minutes.
Finally we have an integration test passing!
This shoudl not be necessary, but it looks that in some situations for long-running jobs memory usage keeps increasing until running into an OOM error. We already had a use case where manually calling gc helped, it would be good if others could test as well if this would help for their use case @TabeaW @Qfl3x .