Open lazarusA opened 1 year ago
Totals | |
---|---|
Change from base Build 5425877586: | 0.0% |
Covered Lines: | 1353 |
Relevant Lines: | 1785 |
Patch and project coverage have no change.
Comparison is base (
08f1d8f
) 75.82% compared to head (33ba3e9
) 75.82%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @lazarusA Sure, I'll can improve my example. However, I don't have permissions to push to any branch of this repo, bc. I'm not a developer of YAXArrays (yet).
you could continue on your own branch. And then do a normal PR as usual. No need to push to someone else's branch, actually you shouldn't do it :D.
@danlooo sorry, I rebase your pr against master, since it changed a lot in the past few days, could you please continue with this branch. Specially the concerns raised by fabian here: https://github.com/JuliaDataCubes/YAXArrays.jl/pull/270