JuliaDataCubes / YAXArrays.jl

Yet Another XArray-like Julia package
https://juliadatacubes.github.io/YAXArrays.jl/
Other
89 stars 14 forks source link

max_cache human writing #334

Closed dpabon closed 9 months ago

dpabon commented 10 months ago

max_cache in bits is fine, but not very human friendly. This is a downstream implementation of the YAXArraysToolbox package to get max_cache as e.g. max_cache="100MB" that can be useful for users of the YAXArrays package.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/DAT/DAT.jl 77.26% <83.33%> (+0.07%) :arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.

meggart commented 9 months ago

Thanks a lot for the PR. Something seems to be strange since I can see a series of commits, but it looks like there are no changes to the files. Don't know if the error is on my side @felixcremer do you see proposed changes?

dpabon commented 9 months ago

Thanks Fabian, you're right, somehow I reverted the changes on the branch. Now you should be able to see the changes.

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 6301293873


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DAT/DAT.jl 1 6 16.67%
<!-- Total: 1 6 16.67% -->
Totals Coverage Status
Change from base Build 6227357617: -0.1%
Covered Lines: 1019
Relevant Lines: 1740

💛 - Coveralls
lazarusA commented 9 months ago

@dpabon please add some tests, if you can.