try to fix Ti error

[kongdd]

try to fix #336, #330, #320, might also works for #301

This issue is related to DD.dim2key(ti) and DD.name(ti). They return different values.

using DimensionalData
using DimensionalData: DimensionalData as DD
using Dates

ti = Ti(DateTime(2001):Month(1):DateTime(2002))

@show DD.dim2key(ti);
@show DD.name(ti);

DD.dim2key(ti) = :Ti
DD.name(ti) = :Time

[lazarusA]

Thanks for this PR, could you please try to include a test example. For now, I approved CI to check if nothing breaks as it is.

[kongdd]

Thank you. After all tests passed, I will add new.

[codecov[bot]]

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files	Coverage Δ
src/DatasetAPI/Datasets.jl	76.92% <100.00%> (+41.77%)	:arrow_up:

... and 2 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

[kongdd]

@lazarusA, do you know about the Broken in tests?

It shows that 9 broken. But I can't found out which test failed.

https://github.com/JuliaDataCubes/YAXArrays.jl/actions/runs/6368945266/job/17288790299?pr=337

[kongdd]

The test of Datasets is commented. I am not sure whether should I uncomment this line. https://github.com/JuliaDataCubes/YAXArrays.jl/blob/4f4f555cb1583dff91e437bbd684a7de471ed498/test/runtests.jl#L15

[kongdd]

https://github.com/JuliaDataCubes/YAXArrays.jl/issues/336, https://github.com/JuliaDataCubes/YAXArrays.jl/issues/330 are solved now. https://github.com/JuliaDataCubes/YAXArrays.jl/issues/320 should also be. But I have no data to test.

[lazarusA]

I'm doing another CI run. Let's see, I cannot do much today, only things from my phone. I could take a deeper look once I'm at my computer

[kongdd]

Thank you @lazarusA. An ugly test was added here. All tests in datasets.jl are uncommented and passsed now.

[lazarusA]

Could you use https://juliadatacubes.github.io/YAXArrays.jl/dev/examples/generated/UserGuide/openNetCDF/ ? It's Ti still appearing when reading the files?

[kongdd]

Sure. New test Added and Passed.

[kongdd]

I found both of DD.dim2key and DD.name are used in YAXArrays.jl. Their different return values might lead to bugs unexpectedly.