search

JuliaDataCubes / YAXArrays.jl

Yet Another XArray-like Julia package
https://juliadatacubes.github.io/YAXArrays.jl/
Other
89 stars 12 forks source link

Make Metadata a type parameter of YAXArray #370

Closed felixcremer closed 4 months ago

felixcremer commented 4 months ago

This is similarly done for DimArray. This allows to use the NoMetadata type from DimensionalData.LookupArray in a YAXArray which is used as a default in some DimensionalData functions.

This would close https://github.com/rafaqz/DimensionalData.jl/issues/641

I also removed a test which should rather live in DimensionalData because it does not test YAXArray functionality.

github-actions[bot] commented 4 months ago
Benchmark result # Judge result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmarks: - Target: 22 Feb 2024 - 13:28 - Baseline: 22 Feb 2024 - 13:29 * Package commits: - Target: 6e01db - Baseline: 00c381 * Julia commits: - Target: 7790d6 - Baseline: 7790d6 * Julia command flags: - Target: None - Baseline: None * Environment variables: - Target: None - Baseline: None ## Results A ratio greater than `1.0` denotes a possible regression (marked with :x:), while a ratio less than `1.0` denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds). | ID | time ratio | memory ratio | |--------------------------|------------------------------|------------------------------| | `["mapslices", "small"]` | 0.03 (5%) :white_check_mark: | 0.31 (1%) :white_check_mark: | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ### Target ``` Julia Version 1.10.1 Commit 7790d6f0641 (2024-02-13 20:41 UTC) Build Info: Official https://julialang.org/ release Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.4 LTS uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64 CPU: AMD EPYC 7763 64-Core Processor: speed user nice sys idle irq #1 2445 MHz 864 s 0 s 96 s 3106 s 0 s #2 2445 MHz 895 s 0 s 114 s 3063 s 0 s #3 3242 MHz 954 s 0 s 124 s 2978 s 0 s #4 3242 MHz 888 s 0 s 106 s 3067 s 0 s Memory: 15.60690689086914 GB (13732.484375 MB free) Uptime: 409.56 sec Load Avg: 1.59 1.11 0.49 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-15.0.7 (ORCJIT, znver3) Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores) ``` ### Baseline ``` Julia Version 1.10.1 Commit 7790d6f0641 (2024-02-13 20:41 UTC) Build Info: Official https://julialang.org/ release Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.4 LTS uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64 CPU: AMD EPYC 7763 64-Core Processor: speed user nice sys idle irq #1 3221 MHz 876 s 0 s 98 s 3349 s 0 s #2 3242 MHz 947 s 0 s 118 s 3264 s 0 s #3 2445 MHz 1109 s 0 s 128 s 3076 s 0 s #4 2591 MHz 921 s 0 s 109 s 3289 s 0 s Memory: 15.60690689086914 GB (13803.57421875 MB free) Uptime: 435.38 sec Load Avg: 1.39 1.1 0.51 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-15.0.7 (ORCJIT, znver3) Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores) ``` --- # Target result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmark: 22 Feb 2024 - 13:28 * Package commit: 6e01db * Julia commit: 7790d6 * Julia command flags: None * Environment variables: None ## Results Below is a table of this job's results, obtained by running the benchmarks. The values listed in the `ID` column have the structure `[parent_group, child_group, ..., key]`, and can be used to index into the BaseBenchmarks suite to retrieve the corresponding benchmarks. The percentages accompanying time and memory values in the below table are noise tolerances. The "true" time/memory value for a given benchmark is expected to fall within this percentage of the reported value. An empty cell means that the value was zero. | ID | time | GC time | memory | allocations | |--------------------------|----------------:|-----------:|----------------:|------------:| | `["mapslices", "small"]` | 272.363 ms (5%) | 193.838 ms | 330.27 MiB (1%) | 91076 | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ``` Julia Version 1.10.1 Commit 7790d6f0641 (2024-02-13 20:41 UTC) Build Info: Official https://julialang.org/ release Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.4 LTS uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64 CPU: AMD EPYC 7763 64-Core Processor: speed user nice sys idle irq #1 2445 MHz 864 s 0 s 96 s 3106 s 0 s #2 2445 MHz 895 s 0 s 114 s 3063 s 0 s #3 3242 MHz 954 s 0 s 124 s 2978 s 0 s #4 3242 MHz 888 s 0 s 106 s 3067 s 0 s Memory: 15.60690689086914 GB (13732.484375 MB free) Uptime: 409.56 sec Load Avg: 1.59 1.11 0.49 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-15.0.7 (ORCJIT, znver3) Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores) ``` --- # Baseline result # Benchmark Report for */home/runner/work/YAXArrays.jl/YAXArrays.jl* ## Job Properties * Time of benchmark: 22 Feb 2024 - 13:29 * Package commit: 00c381 * Julia commit: 7790d6 * Julia command flags: None * Environment variables: None ## Results Below is a table of this job's results, obtained by running the benchmarks. The values listed in the `ID` column have the structure `[parent_group, child_group, ..., key]`, and can be used to index into the BaseBenchmarks suite to retrieve the corresponding benchmarks. The percentages accompanying time and memory values in the below table are noise tolerances. The "true" time/memory value for a given benchmark is expected to fall within this percentage of the reported value. An empty cell means that the value was zero. | ID | time | GC time | memory | allocations | |--------------------------|-------------:|-----------:|--------------:|------------:| | `["mapslices", "small"]` | 7.883 s (5%) | 841.538 ms | 1.03 GiB (1%) | 10882637 | ## Benchmark Group List Here's a list of all the benchmark groups executed by this job: - `["mapslices"]` ## Julia versioninfo ``` Julia Version 1.10.1 Commit 7790d6f0641 (2024-02-13 20:41 UTC) Build Info: Official https://julialang.org/ release Platform Info: OS: Linux (x86_64-linux-gnu) Ubuntu 22.04.4 LTS uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64 CPU: AMD EPYC 7763 64-Core Processor: speed user nice sys idle irq #1 3221 MHz 876 s 0 s 98 s 3349 s 0 s #2 3242 MHz 947 s 0 s 118 s 3264 s 0 s #3 2445 MHz 1109 s 0 s 128 s 3076 s 0 s #4 2591 MHz 921 s 0 s 109 s 3289 s 0 s Memory: 15.60690689086914 GB (13803.57421875 MB free) Uptime: 435.38 sec Load Avg: 1.39 1.1 0.51 WORD_SIZE: 64 LIBM: libopenlibm LLVM: libLLVM-15.0.7 (ORCJIT, znver3) Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores) ``` --- # Runtime information | Runtime Info | | |:--|:--| | BLAS #threads | 2 | | `BLAS.vendor()` | `lbt` | | `Sys.CPU_THREADS` | 4 | `lscpu` output: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 48 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 4 On-line CPU(s) list: 0-3 Vendor ID: AuthenticAMD Model name: AMD EPYC 7763 64-Core Processor CPU family: 25 Model: 1 Thread(s) per core: 2 Core(s) per socket: 2 Socket(s): 1 Stepping: 1 BogoMIPS: 4890.85 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm Virtualization: AMD-V Hypervisor vendor: Microsoft Virtualization type: full L1d cache: 64 KiB (2 instances) L1i cache: 64 KiB (2 instances) L2 cache: 1 MiB (2 instances) L3 cache: 32 MiB (1 instance) NUMA node(s): 1 NUMA node0 CPU(s): 0-3 Vulnerability Gather data sampling: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected | Cpu Property | Value | |:------------------ |:---------------------------------------------------------- | | Brand | AMD EPYC 7763 64-Core Processor | | Vendor | :AMD | | Architecture | :Unknown | | Model | Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00 | | Cores | 16 physical cores, 16 logical cores (on executing CPU) | | | No Hyperthreading hardware capability detected | | Clock Frequencies | Not supported by CPU | | Data Cache | Level 1:3 : (32, 512, 32768) kbytes | | | 64 byte cache line size | | Address Size | 48 bits virtual, 48 bits physical | | SIMD | 256 bit = 32 byte max. SIMD vector size | | Time Stamp Counter | TSC is accessible via `rdtsc` | | | TSC runs at constant rate (invariant from clock frequency) | | Perf. Monitoring | Performance Monitoring Counters (PMC) are not supported | | Hypervisor | Yes, Microsoft |
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8005252794

Details

Totals Coverage Status
Change from base Build 7965996151: 0.0%
Covered Lines: 1212
Relevant Lines: 1751
💛 - Coveralls
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (00c381d) 68.43% compared to head (08b7b19) 68.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #370 +/- ## ======================================= Coverage 68.43% 68.43% ======================================= Files 12 12 Lines 1771 1771 ======================================= Hits 1212 1212 Misses 559 559 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lazarusA commented 4 months ago

all tests passed. I will merge this.