search

JuliaDataCubes / YAXArrays.jl

Yet Another XArray-like Julia package
https://juliadatacubes.github.io/YAXArrays.jl/
Other
89 stars 12 forks source link

Bump DimensionalData dependency to 0.27 #390

Closed felixcremer closed 2 months ago

felixcremer commented 2 months ago

This replaces the deprecated DimensionalData functions key2dim and dim2key with their new versions.

The fix seemed to be very smooth but I am not sure whether this is breaking, because it might change the behaviour of the Ti and time axes.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8923198631

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Cubes/Slices.jl 0 1 0.0%
src/DAT/registration.jl 0 1 0.0%
src/DAT/DAT.jl 0 2 0.0%
src/DatasetAPI/Datasets.jl 3 5 60.0%
src/Cubes/Cubes.jl 3 6 50.0%
src/DAT/tablestats.jl 2 6 33.33%
<!-- Total: 9 22 40.91% -->
Totals Coverage Status
Change from base Build 8786965965: 0.0%
Covered Lines: 1207
Relevant Lines: 1769
💛 - Coveralls
lazarusA commented 2 months ago

you need to bump also the version of DD for docs.

felixcremer commented 2 months ago

I don't understand why this failed, because the docs/Project.toml does not specify a version for any packages for good reason. I just restarted the job and hope, that it works.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (a287107) to head (3d6ebc9). Report is 2 commits behind head on master.

:exclamation: Current head 3d6ebc9 differs from pull request most recent head c6af482. Consider uploading reports for the commit c6af482 to get more accurate results

Files Patch % Lines
src/DAT/tablestats.jl 33.33% 4 Missing :warning:
src/Cubes/Cubes.jl 50.00% 3 Missing :warning:
src/DAT/DAT.jl 0.00% 2 Missing :warning:
src/DatasetAPI/Datasets.jl 60.00% 2 Missing :warning:
src/Cubes/Slices.jl 0.00% 1 Missing :warning:
src/DAT/registration.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #390 +/- ## ========================================== - Coverage 68.15% 67.34% -0.81% ========================================== Files 12 12 Lines 1771 1770 -1 ========================================== - Hits 1207 1192 -15 - Misses 564 578 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felixcremer commented 2 months ago

I added a line to update the registry into the Documenter workflow and now the docs build successfully. I also updated the codecov action to 0.4 to hopefully fix the codecove issues on Ubuntu

lazarusA commented 2 months ago

Merge?